Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Error ERR_MODULE_NOT_FOUND in v7 #519

Closed
1 task done
AnnAngela opened this issue Feb 26, 2024 · 3 comments · Fixed by #520
Closed
1 task done

[BUG]: Error ERR_MODULE_NOT_FOUND in v7 #519

AnnAngela opened this issue Feb 26, 2024 · 3 comments · Fixed by #520
Labels
released Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented

Comments

@AnnAngela
Copy link

What happened?

Minimal reproduction environment: https://github.com/AnnAngela/octokit-esm-bug

When importing @octokit/plugin-retry@7, there is an error: https://github.com/AnnAngela/octokit-esm-bug/actions/runs/8042420281/job/21963054016#step:5:11

And I tested to import the bottleneck/light like this:

import Bottleneck from "bottleneck/light";

The error is still happened: https://github.com/AnnAngela/octokit-esm-bug/actions/runs/8042420281/job/21963054016#step:6:11

When I tried to import the bottleneck/light with .js extension, no error anymore: https://github.com/AnnAngela/octokit-esm-bug/actions/runs/8042420281/job/21963054016#step:7:7

Versions

@octokit/plugin-retry: 7.0.0

Node 20.11.1

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@AnnAngela AnnAngela added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Feb 26, 2024
Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member

This bug was hidden because of a // @ts-expect-error, because there are no types for bottleneck/light in the published version on npm

This is certainly a great catch

Copy link

🎉 This issue has been resolved in version 7.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants