-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Error when using retry plugin with codeowners errors request #536
Comments
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with |
🎉 This issue has been resolved in version 7.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 6.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What happened?
the @octokit/plugin-retry package is unable to handle calling the Github API endpoint to list CODEOWNERS errors (https://docs.github.com/en/rest/repos/repos?apiVersion=2022-11-28#list-codeowners-errors).
Since the API endpoint by default is expected to return a list of errors, in the case where there are no errors it will return an empty list. However, the retry plugin specifically checks to see if the errors list exists in the response:
plugin-retry.js/src/wrap-request.ts
Line 37 in dcf1fa3
The retry plugin will then try to log the first error message. This will throw an error if the list is empty.
Here is the code I am using
When I run this code I get an error message from the octokit/plugin-retry, however when I remove the retry plugin, I get a success response.
See the Relevant log output section for the error message I am getting.
Versions
Node v18.16.0, @octokit/core v6.1.1, @octokit/plugin-retry v7.1.0
Relevant log output
Code of Conduct
The text was updated successfully, but these errors were encountered: