test(coverage): adding 100% coverage (#456)

package.json

@@ -49,10 +49,10 @@
     "preset": "ts-jest",
     "coverageThreshold": {
       "global": {
-        "statements": 98,
-        "branches": 96,
-        "functions": 93,
-        "lines": 98
+        "statements": 100,
+        "branches": 100,
+        "functions": 100,
+        "lines": 100
       }
     }
   },

src/index.ts

@@ -45,7 +45,7 @@ const createGroups = function (Bottleneck, common) {
   });
 };
 
-export function throttling(octokit: Octokit, octokitOptions = {}) {
+export function throttling(octokit: Octokit, octokitOptions: object) {
   const {
     enabled = true,
     Bottleneck = BottleneckLight,

test/events.test.ts

@@ -228,4 +228,52 @@ describe("Events", function () {
       expect(eventCount).toEqual(1);
     });
   });
+
+  describe("error", function () {
+    it("logs a warning when an 'error' event is emitted", async function () {
+      const octokit = new TestOctokit({
+        throttle: {
+          onRateLimit: () => {
+            throw new Error("Should not reach this point");
+          },
+          onSecondaryRateLimit: () => {
+            throw new Error("Should not reach this point");
+          },
+        },
+      });
+
+      jest.spyOn(octokit.log, "warn");
+
+      const t0 = Date.now();
+
+      await octokit.request("GET /route1", {
+        request: {
+          responses: [{ status: 201, headers: {}, data: {} }],
+        },
+      });
+      try {
+        await octokit.request("GET /route2", {
+          request: {
+            responses: [
+              {
+                status: 403,
+                headers: {
+                  "x-ratelimit-remaining": "0",
+                  "x-ratelimit-reset": `${Math.round(t0 / 1000) + 30}`,
+                },
+                data: {},
+              },
+            ],
+          },
+        });
+        throw new Error("Should not reach this point");
+      } catch (error: any) {
+        expect(error.status).toEqual(403);
+        expect(octokit.log.warn).toHaveBeenCalledWith(
+          "Error in throttling-plugin limit handler",
+          new Error("Should not reach this point")
+        );
+      }
+    });
+  });
 });

test/plugin.test.ts

@@ -108,6 +108,7 @@ describe("Github API best practices", function () {
         write: new Bottleneck.Group({ minTime: 50 }),
         onSecondaryRateLimit: () => 1,
         onRateLimit: () => 1,
+        connection: new Bottleneck({ minTime: 50 }),
       },
     });