Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(log): use 'octokit.log.warn' instead of 'console.warn' #459

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

oscard0m
Copy link
Member

@oscard0m oscard0m commented Mar 3, 2022

Description

Replace console.warn usage with octokit.log.warn instead

Context

Open the door to users to hook their own Octokit logging system (which uses console.log if not defined).

More context here: #455 (comment)

@oscard0m oscard0m requested a review from gr2m March 3, 2022 08:57
@oscard0m oscard0m added the Type: Maintenance Tests, Refactorings, Automation, etc label Mar 3, 2022
@oscard0m oscard0m requested a review from wolfy1339 March 3, 2022 08:59
@gr2m gr2m merged commit 054cefa into master Mar 3, 2022
@gr2m gr2m deleted the replace-console-warn-with-octokit-log-warn branch March 3, 2022 19:19
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

🎉 This PR is included in version 3.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Tests, Refactorings, Automation, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants