Skip to content

Commit

Permalink
feat: v7 (#586)
Browse files Browse the repository at this point in the history
* ci: stop testing against NodeJS v14, v16 (#581)

BREAKING CHANGE: Drop support for NodeJS v14, v16

* feat: remove `node-fetch` in favor of global (#580)

BREAKING CHANGE: remove `node-fetch` in favor of global

* docs: update ToC for README.md

* fix(deps): update dependency @octokit/request-error to v4 (#587)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix: bump `@octokit/request-error`

* fix(deps): bump `@octokit/types`

* fix(build): bump Octokit deps

* tests: adapt for `@octokit/endpoint` v8

* fix(deps): upgrade to `@octokit/endpoint` v8 stable

---------

Co-authored-by: Steven <[email protected]>
Co-authored-by: prettier-toc-me[bot] <56236715+prettier-toc-me[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Keegan Campbell <[email protected]>
  • Loading branch information
5 people authored Jun 16, 2023
1 parent 62f51d6 commit 517ebab
Show file tree
Hide file tree
Showing 8 changed files with 237 additions and 5,484 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@ jobs:
strategy:
matrix:
node_version:
- 14
- 16
- 18
- 20
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node_version }}
Expand Down
16 changes: 2 additions & 14 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ to interact with [GitHub’s REST API](https://developer.github.com/v3/) and
[GitHub’s GraphQL API](https://developer.github.com/v4/guides/forming-calls/#the-graphql-endpoint).

It uses [`@octokit/endpoint`](https://github.com/octokit/endpoint.js) to parse
the passed options and sends the request using [fetch](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API)
([node-fetch](https://github.com/bitinn/node-fetch) when the runtime has no native `fetch` API).
the passed options and sends the request using [fetch](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API). You can pass a custom `fetch` function using the `options.request.fetch` option, see below.

<!-- update table of contents by running `npx markdown-toc README.md -i` -->

Expand Down Expand Up @@ -319,7 +318,7 @@ const { data: app } = await requestWithAuth(
Function
</td>
<td>
Custom replacement for <a href="https://github.com/bitinn/node-fetch">built-in fetch method</a>. Useful for testing or request hooks.
Custom replacement for <a href="https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API">fetch</a>. Useful for testing or request hooks.
</td>
</tr>
<tr>
Expand Down Expand Up @@ -354,17 +353,6 @@ const { data: app } = await requestWithAuth(
Used for internal logging. Defaults to <a href="https://developer.mozilla.org/en-US/docs/Web/API/console"><code>console</code></a>.
</td>
</tr>
<tr>
<th align=left>
<code>options.request.timeout</code>
</th>
<td>
Number
</td>
<td>
Node only. Request/response timeout in ms, it resets on redirect. 0 to disable (OS limit applies). <a href="#options-request-signal">options.request.signal</a> is recommended instead.
</td>
</tr>
</table>

All other options except `options.request.*` will be passed depending on the `method` and `url` options.
Expand Down
Loading

0 comments on commit 517ebab

Please sign in to comment.