Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Web entrypoint of @octokit/webhooks-methods doesn't provide an export named: 'verifyWithFallback' #1099

Closed
1 task done
dustsucker opened this issue Feb 5, 2025 · 9 comments · Fixed by #1103
Closed
1 task done
Labels
released Type: Bug Something isn't working as documented, or is being fixed

Comments

@dustsucker
Copy link

What happened?

As of Today( or last week, i don't know got the error today) Octokit seems to be broken. It worked before. I got the error:
Uncaught SyntaxError: The requested module 'https://esm.sh/@octokit/webhooks-methods@%5E5.0.0?target=es2022' doesn't provide an export named: 'verifyWithFallback'
it seems to be realteted to: 8a9682d as it seems to reference a change made in this commit.

Versions

https://esm.sh/octokit (latest)

Relevant log output

Uncaught SyntaxError: The requested module 'https://esm.sh/@octokit/webhooks-methods@%5E5.0.0?target=es2022' doesn't provide an export named: 'verifyWithFallback'

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dustsucker dustsucker added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented, or is being fixed labels Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@github-project-automation github-project-automation bot moved this to 🆕 Triage in 🧰 Octokit Active Feb 5, 2025
@wolfy1339
Copy link
Member

That's odd because that function is exported, https://github.com/octokit/webhooks-methods.js/blob/cb8d6f763aee4548050f50b0dc6032569bb4c28a/src/index.ts#L5

It seems that ESM.sh is taking the browser build, which doesn't include that function export.

@fmorency
Copy link

fmorency commented Feb 5, 2025

I'm also seeing this today.

Failed to compile.

./node_modules/@octokit/webhooks/dist-bundle/index.js
Attempted import error: 'verifyWithFallback' is not exported from '@octokit/webhooks-methods' (imported as 'verifyWithFallback').

Edit: As a workaround, one can use

"resolutions": {
   "@octokit/webhooks": "13.4.3"
}

in packages.json.

fmorency added a commit to fmorency/manifest-app that referenced this issue Feb 5, 2025
- `cosmos-kit` 2.23.10 is currently broken.
  hyperweb-io/cosmos-kit#540
  Fixing to 2.23.9

- `@octokit/webhooks` 13.5.0 is currently broken.
  octokit/webhooks.js#1099
  Fixing to 13.4.3
fmorency added a commit to liftedinit/manifest-app that referenced this issue Feb 5, 2025
- `cosmos-kit` 2.23.10 is currently broken.
  hyperweb-io/cosmos-kit#540
  Fixing to 2.23.9

- `@octokit/webhooks` 13.5.0 is currently broken.
  octokit/webhooks.js#1099
  Fixing to 13.4.3
@wolfy1339
Copy link
Member

octokit/webhooks-methods.js#312 will fix this

@wolfy1339 wolfy1339 removed the Status: Triage This is being looked at and prioritized label Feb 5, 2025
@wolfy1339 wolfy1339 moved this from 🆕 Triage to 🏗 In progress in 🧰 Octokit Active Feb 5, 2025
@wolfy1339 wolfy1339 marked this as a duplicate of octokit/octokit.js#2803 Feb 5, 2025
@wolfy1339 wolfy1339 changed the title [BUG]: Uncaught SyntaxError: The requested module 'https://esm.sh/@octokit/webhooks-methods@%5E5.0.0?target=es2022' doesn't provide an export named: 'verifyWithFallback' [BUG]: Web entrypoint of @octokit/webhooks-methods doesn't provide an export named: 'verifyWithFallback' Feb 5, 2025
@buesing
Copy link

buesing commented Feb 6, 2025

Hello, thanks for the quick fix. May I ask when this will be released? The entire octokit library is broken right now for me.

@wolfy1339
Copy link
Member

I can only do so much, I don't have the powers to merge PRs by myself.

I'm at the mercy of when another person that has write access reviews the PR

@wolfy1339
Copy link
Member

For those of you using NPM/Yarn/PNPM you will be able to update @octokit/webhooks-methods to version 5.1.1
For those of you using ESM.sh, you will have to wait a little bit as I need to upgrade the version in #1103, then in @octokit/app then in octokit

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in 🧰 Octokit Active Feb 6, 2025
Copy link
Contributor

github-actions bot commented Feb 6, 2025

🎉 This issue has been resolved in version 13.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@wolfy1339
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented, or is being fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants