-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve header validation #1094
base: main
Are you sure you want to change the base?
Conversation
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
This doesn't really seem like an improvement to me as we're now only reporting a single missing header, and using more code to do so? |
The benefit is to avoid creating arrays and strings, over and over. |
What about now? It avoids as I wrote unneccessary array and string generation. |
I don't think we need to use binary here. Let's keep this simple.... |
I actually want more performance. |
While more performance is always good. At what point do we really need to sacrifice readability and understanding for performance. |
takes the header validation logic from #932