Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve header validation #1094

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Jan 28, 2025

takes the header validation logic from #932

Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@G-Rath
Copy link
Member

G-Rath commented Jan 29, 2025

This doesn't really seem like an improvement to me as we're now only reporting a single missing header, and using more code to do so?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Jan 30, 2025

@G-Rath

The benefit is to avoid creating arrays and strings, over and over.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Jan 30, 2025

@G-Rath

What about now? It avoids as I wrote unneccessary array and string generation.

@wolfy1339
Copy link
Member

I don't think we need to use binary here. Let's keep this simple....

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Jan 30, 2025

I actually want more performance.

@wolfy1339
Copy link
Member

While more performance is always good. At what point do we really need to sacrifice readability and understanding for performance.
Let's keep it stupid simple

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 Triage
Development

Successfully merging this pull request may close these issues.

3 participants