Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for formatting large request bodies + Windows Test Fixes #1

Merged
merged 11 commits into from
Mar 15, 2021

Conversation

cholladay0816
Copy link

This PR is to fix an issue with oversized requests due to escapeshellargs byte limits. It also includes code to help make the tests pass on Windows.

  • Fixed a major bug that would cause large requests to blow up. This was achieved by replacing escapeshellargs with an escapeShellArgument function, which uses Symfony Processes to accomplish the same thing without memory restrictions. (Thanks to @adduc for this solution, Add support for formatting large request bodies namshi/cuzzle#22)
  • Includes a str_replace function in the test files to convert double quotes to single quotes, allowing the comparisons to work on Windows machines.

@cholladay0816 cholladay0816 marked this pull request as ready for review March 10, 2021 23:52
@octoper
Copy link
Owner

octoper commented Mar 15, 2021

@cholladay0816 Thank you!

@octoper octoper merged commit d644aaf into octoper:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants