Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gzip-compressed mimetype if download one compressed file #726

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

dsavchenko
Copy link
Member

@dsavchenko dsavchenko commented Jan 8, 2025

To fix wrong mimetype mentioned in #724 (comment)

Also includes marshmellow version restriction (new incompatible update is several days old). Break is due to use of "private" variable here

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.09%. Comparing base (a45dccd) to head (8f44325).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #726   +/-   ##
=======================================
  Coverage   62.09%   62.09%           
=======================================
  Files          50       50           
  Lines        9167     9168    +1     
=======================================
+ Hits         5692     5693    +1     
  Misses       3475     3475           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@burnout87 burnout87 mentioned this pull request Jan 8, 2025
@burnout87
Copy link
Collaborator

anything to comment on this @volodymyrss ?

@dsavchenko
Copy link
Member Author

@volodymyrss this has priority: the main change itself is minor, but the marshmallow version restriction is important.
Please review

Copy link
Member

@volodymyrss volodymyrss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for reminding!

@burnout87 burnout87 merged commit 718ff2d into master Jan 9, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants