-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not fetch disabled links, but copy over all attributes to new link. #262
Conversation
✅ Deploy Preview for anchor-position-wpt canceled.
|
✅ Deploy Preview for anchor-polyfill ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
* main: Add more waiting in tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think in addition to the mutation observer, we may still want to separately address things like integrity
or referrerpolicy
, or event handlers that we don't want to bring over. These were initially raised in #242.
Hm, good point. Do you think it would be worth compiling a list of either the attributes we want to explicitly exclude, or explicitly include? It's not perfect, but might be better than either the current implementation or this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
Description
This doesn't yet include the full fix for #246 because we don't have a robust solution for running the polyfill multiple times on the same page, but it makes two changes:
disabled
are now ignored entirely.Related Issue(s)
Fixes #254.