Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add random ellipsoid phantom #1315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kohr-h
Copy link
Member

@kohr-h kohr-h commented Mar 23, 2018

This might be useful.

Copy link
Member

@adler-j adler-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall very good, but since this is actually somewhat speed critical (people would use it in e.g. ML) I think we need to be more careful. Specifically we should try to do away with all the "while" loops, especially globally. If we cannot do that, at least move them locally.

@kohr-h
Copy link
Member Author

kohr-h commented Mar 31, 2018

I admit this is the lazy implementation. I'll make one that checks overlap with the coordinates only.

@kohr-h
Copy link
Member Author

kohr-h commented Apr 26, 2018

I've done some work on this a while ago, but it turned out that it's nontrivial to efficiently determine whether an ellipsoid intersects another one, apart from trivial situations. I've got one pending idea that's not implemented yet, which is to transform the coordinates such that the "query ellipsoid" becomes a ball -- this reduces the problem to determining the distance of an ellipsoid to the origin.

Other suggestions are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants