[Twig] allow to use string phone numbers in templates filters #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhelias
approved these changes
Feb 16, 2023
Nek-
reviewed
Feb 16, 2023
Nek-
reviewed
Feb 16, 2023
|
Hello @oleg-andreyev , thank you very much for your contribution, it's extremely relevant. Could you please however take a look at this? I'd like also @maxhelias @jderusse @odolbeau to have a look to my comment if possible. |
Nek-
changed the title
Nek-
approved these changes
Mar 22, 2023
maxhelias
approved these changes
Mar 22, 2023
|
Thanks @oleg-andreyev ! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with any templating enging in most cases we work with string and objects.
This PR allows using string for Twig filters.