Increase PHPStan level #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we can go for a new major version, it's time to move on ;D |
maxhelias
reviewed
Nov 30, 2023
| @@ -1,5 +1,7 @@ | |||
| <?php | |||
|
|
|||
| declare(strict_types=1); | |||
|
|
|||
| /* | |||
| * This file is part of the Symfony2 PhoneNumberBundle. | |||
There was a problem hiding this comment.
What do you think of the file header update?
There was a problem hiding this comment.
This is a good idea!
I discovered recently that's is something supported by php-cs : https://github.com/symfony/symfony/blob/7.1/.php-cs-fixer.dist.php#L16
Maybe we can open an issue / PR in order to decide of a header we want to have in all files?
odolbeau
force-pushed
the
increase-phptan-level
branch
from
bf79645 to
02f93fa
Compare
|
|
odolbeau
force-pushed
the
increase-phptan-level
branch
from
02f93fa to
f5770c3
Compare
maxhelias
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably break the BC promise and its probably not complete : there's probably other non strict typed methods I should take care of.
WDYT about this, should we go for a new major version with strict typing?
If yes, is there anything else we would like to include in a new major version?