Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty PhoneNumber object to be transformed in form #179

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

nicodemuz
Copy link

I have an entity that does not allow a NULL value for phone number:

    #[ORM\Column(type: 'phone_number', nullable: false)]
    #[AssertPhoneNumber]
    private PhoneNumber $phone;

This change allows an empty PhoneNumber object to be transformed to be displayed on the form.

@odolbeau
Copy link
Owner

odolbeau commented Nov 4, 2024

Hi @nicodemuz & thanks a lot for your contribution!

I'm sorry for the very late answer! 🙈

Static analysis have bee corrected in #180, could you please rebase your branch?

@nicodemuz
Copy link
Author

Hi @nicodemuz & thanks a lot for your contribution!

I'm sorry for the very late answer! 🙈

Static analysis have bee corrected in #180, could you please rebase your branch?

I have updated my branch. The tests are now passing.

@odolbeau
Copy link
Owner

odolbeau commented Nov 8, 2024

Thanks for your contribution!

@odolbeau odolbeau merged commit 2d5ff5f into odolbeau:master Nov 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants