Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Bootstrap 5 #79

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Conversation

ker0x
Copy link

@ker0x ker0x commented Jun 15, 2021

No description provided.

@ker0x ker0x force-pushed the feature/issue-75 branch from 31c3b8b to 06ca603 Compare June 15, 2021 10:52
@ker0x ker0x mentioned this pull request Jun 15, 2021
5 tasks
Copy link
Collaborator

@maxhelias maxhelias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM !

@@ -14,7 +14,8 @@
"require": {
"php": ">7.2.5",
"giggsey/libphonenumber-for-php": "^8.0",
"symfony/framework-bundle": "^3.4|^4.3|^5.0"
"symfony/framework-bundle": "^3.4|^4.3|^5.0",
"symfony/intl": "^3.4|^4.3|^5.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, the intl component is no longer embedded in the form component since 5.3 👍
Just for the record : symfony/symfony#40298

@maxhelias maxhelias merged commit 0b71d42 into odolbeau:master Jun 28, 2021
@maxhelias
Copy link
Collaborator

Thanks @ker0x ! 😉

@ker0x ker0x deleted the feature/issue-75 branch June 28, 2021 15:33
@maxhelias maxhelias mentioned this pull request Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants