Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Among other small bug fixes this update adds support for the
eu-south-2
,eu-central-2
,me-central-1
,ap-southeast-3
AWS endpoints.I have tested this update by creating a S3 bucket on the EU (Zurich)
eu-central-2
endpoint and being successfully able to store a backup to it.Furthermore, I have also tried running the tests by replacing all occurrences of the image
offen/docker-volume-backup:${TEST_VERSION:-canary}
with my locally built image (I am not sure whether that is the correct approach). However, I got stuck on thecommands/run.sh
test case because of a reference to/var/lib/docker/volumes/commands_archive/_data
. I cannot resolve this path on macOS and Windows (using WSL2 Ubuntu), which leads me to assume that the tests might need to be run on a Linux OS. Unfortunately, I currently do not have a Linux OS on hand, but I can set up a quick VM tomorrow and try running the tests again if need be.This PR addresses the issue #166.