Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MinIO Go SDK to v7.0.44 #167

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Update MinIO Go SDK to v7.0.44 #167

merged 1 commit into from
Nov 21, 2022

Conversation

freix1
Copy link
Contributor

@freix1 freix1 commented Nov 21, 2022

Among other small bug fixes this update adds support for the eu-south-2, eu-central-2, me-central-1, ap-southeast-3 AWS endpoints.

I have tested this update by creating a S3 bucket on the EU (Zurich) eu-central-2 endpoint and being successfully able to store a backup to it.

Furthermore, I have also tried running the tests by replacing all occurrences of the image offen/docker-volume-backup:${TEST_VERSION:-canary} with my locally built image (I am not sure whether that is the correct approach). However, I got stuck on the commands/run.sh test case because of a reference to /var/lib/docker/volumes/commands_archive/_data. I cannot resolve this path on macOS and Windows (using WSL2 Ubuntu), which leads me to assume that the tests might need to be run on a Linux OS. Unfortunately, I currently do not have a Linux OS on hand, but I can set up a quick VM tomorrow and try running the tests again if need be.

This PR addresses the issue #166.

Adds support for the eu-south-2, eu-central-2, me-central-1, ap-southeast-3 AWS endpoints
@m90
Copy link
Member

m90 commented Nov 21, 2022

Unfortunately, I currently do not have a Linux OS on hand, but I can set up a quick VM tomorrow and try running the tests again if need be.

CircleCI can do this for us, we'll see if the test pass very soon.

Copy link
Member

@m90 m90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks for taking care of updating and also testing this against live infrastructure.

@m90 m90 merged commit 08bafdb into offen:main Nov 21, 2022
@m90
Copy link
Member

m90 commented Nov 21, 2022

Unfortunately, I currently do not have a Linux OS on hand, but I can set up a quick VM tomorrow and try running the tests again if need be.

For future reference, I usually build the image tagged canary myself and then run the tests, but then again I am on Linux which probably is an unfair advantage in this scenario. I don't really know how well the setup works on Mac or WSL. Pushing and having CircleCI run the tests should be a viable alternative in any case though.

@m90
Copy link
Member

m90 commented Nov 21, 2022

This is now released in v2.22.2. Thanks for your contribution 🎩

@freix1
Copy link
Contributor Author

freix1 commented Nov 21, 2022

For future reference, I usually build the image tagged canary myself and then run the tests, but then again I am on Linux which probably is an unfair advantage in this scenario. I don't really know how well the setup works on Mac or WSL. Pushing and having CircleCI run the tests should be a viable alternative in any case though.

Thank you very much for the clarification. It definitely makes sense to just let CircleCI run the tests and thus avoid the trouble of having to deal with individual OS related problems.

I am very grateful for the speedy response and release as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants