Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some dead code in tests_modify (views.py). #1853

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Remove some dead code in tests_modify (views.py). #1853

merged 1 commit into from
Dec 9, 2023

Conversation

vdbergh
Copy link
Contributor

@vdbergh vdbergh commented Dec 3, 2023

This should fix #1843 (comment)

@ppigazzini ppigazzini added server server side changes refactoring non functional code improvement enhancement and removed refactoring non functional code improvement labels Dec 8, 2023
ppigazzini
ppigazzini approved these changes Dec 9, 2023
View reviewed changes
Copy link
Collaborator

@ppigazzini ppigazzini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on DEV: logs clean after modifying some tests.

@ppigazzini ppigazzini merged commit 9614c4e into official-stockfish:master Dec 9, 2023
17 checks passed
@ppigazzini
Copy link
Collaborator

PROD updated, thank you @vdbergh :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppigazzini ppigazzini ppigazzini approved these changes

Assignees
No one assigned
Labels
enhancement server server side changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vdbergh @ppigazzini