Synchronize flush_all(). #2191
Merged
Synchronize flush_all(). #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The former comment about deadlock seems outdated to me. Signal handlers run in the main thread and Fishtest executes no code in the main thread once initialization is finished. So signal handlers behave like asynchronous events in the same way as api calls do, and the latter appear currently to be deadlock free.
vdbergh
force-pushed
the
signal_handler
branch
from
f6011a9 to
df4501d
Compare
ppigazzini
added
enhancement
server
ppigazzini
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Looks good on DEV, I will update PROD after the merge, thank you @vdbergh :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former comment about deadlock seems outdated to me. Signal handlers run in the main thread and Fishtest executes no code in the main thread once initialization is finished. So signal handlers behave like asynchronous events in the same way as api calls do, and the latter appear currently to be deadlock free.
In a second commit we make a small tweak in the procedure to stop the scheduler.