Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect storage key for access token in signOut method #422

Closed
E-Kuerschner opened this issue Jul 17, 2020 · 2 comments
Closed

Incorrect storage key for access token in signOut method #422

E-Kuerschner opened this issue Jul 17, 2020 · 2 comments

Comments

@E-Kuerschner
Copy link

Library version: 3.1.4

Offending line:

accessToken = await sdk.tokenManager.get('token');

In literally every other piece of documentation online the access token is shown being stored under the key "accessToken". What this means is if a dev is following the official Okta guides (as one would assume they would do) then the revokeAccessToken feature will work incorrectly.

@swiftone
Copy link
Contributor

@E-Kuerschner - Good catch, the definitely looks wrong. We'll fix and add tests.

Internal Ref: OKTA-315806

@shuowu
Copy link
Contributor

shuowu commented Jul 29, 2020

Link the fix PR here: #436
Pending for release.

@shuowu shuowu closed this as completed Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants