Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bad accessToken key in signOut #436

Merged
merged 2 commits into from
Jul 29, 2020
Merged

fix: bad accessToken key in signOut #436

merged 2 commits into from
Jul 29, 2020

Conversation

shuowu
Copy link
Contributor

@shuowu shuowu commented Jul 29, 2020

No description provided.

aarongranick-okta
aarongranick-okta approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@aarongranick-okta aarongranick-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding constants. Hardcoded strings was how this mistake crept in.

@shuowu-okta shuowu-okta merged commit e020f5b into master Jul 29, 2020
This was referenced Jul 29, 2020
Closed
Merged
@swiftone swiftone mentioned this pull request Jul 30, 2020
Closed
aarongranick-okta pushed a commit that referenced this pull request Sep 17, 2020
@shuowu @aarongranick-okta
fix: bad accessToken key in signOut (#436)
afdc14c
aarongranick-okta pushed a commit that referenced this pull request Sep 18, 2020
@shuowu @aarongranick-okta
fix: bad accessToken key in signOut (#436)
4282aea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongranick-okta aarongranick-okta aarongranick-okta approved these changes

@swiftone swiftone Awaiting requested review from swiftone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shuowu @aarongranick-okta @shuowu-okta