Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds region from env var to config #203

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

sudolibre
Copy link

This PR is to fix the issue when you set the OKTA_AWSCLI_AWS_REGION via env var the region does not get saved in the profile. If we add the env var value to config here it gets saved as expected.

Copy link
Collaborator

@monde monde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sudolibre this will go out in the next release.

@monde
Copy link
Collaborator

monde commented Jul 2, 2024

@sudolibre we have merge protections on all commits being signed. Can you update your PR with signed commits?

@monde monde merged commit 07c84c9 into okta:master Jul 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants