Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AD - Update React Redirect #5236

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brianduffield-okta
Copy link
Contributor

Description:

  • What's changed? Adding Alisa's branch
  • Is this PR related to a Monolith release? n/a

Resolves:

  • n/a

@acrolinxdevdocs-okta
Copy link
Contributor

Acrolinx score

A minimum Acrolinx Score of 80 is required. The total score is an average of the subscores.

Select Total score to review the Acrolinx scorecard for your article. Try to increase your individual scores, for example: Correctness. Your content will be clearer and more consistent.

Article Total score
Required:80
Word and phrases
(Brand, terms)
Preferred: 80
Correctness
(Spelling, grammar)
Preferred: 80
Clarity
(Readability)
Preferred: 80
Inclusive language
(+ accesibility)
Preferred: 80
packages/@okta/vuepress-site/docs/guides/sign-into-spa-redirect/main/react/addconfigpkg.md 87 14 100 100 100
packages/@okta/vuepress-site/docs/guides/sign-into-spa-redirect/main/react/configmid.md 94 58 100 100 100
packages/@okta/vuepress-site/docs/guides/sign-into-spa-redirect/main/react/createproject.md 85 100 42 100 100
packages/@okta/vuepress-site/docs/guides/sign-into-spa-redirect/main/react/getuserinfo.md 100 100 100 100 100
packages/@okta/vuepress-site/docs/guides/sign-into-spa-redirect/main/react/handlecallback.md 100 100 100 100 100
packages/@okta/vuepress-site/docs/guides/sign-into-spa-redirect/main/react/loginredirect.md 72 13 38 100 55
packages/@okta/vuepress-site/docs/guides/sign-into-spa-redirect/main/react/redirectvalues.md 74 12 100 12 100
packages/@okta/vuepress-site/docs/guides/sign-into-spa-redirect/main/react/specificlinks.md 73 42 42 100 100
packages/@okta/vuepress-site/docs/guides/sign-into-spa-redirect/main/react/useaccesstoken.md 90 100 100 100 100

@eng-info-dev-github-bot

Netlify Preview URL for the changes: https://preview-5236--reverent-murdock-829d24.netlify.app

Copy link
Contributor

@alisaduncan alisaduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the same updates here in this PR's commit as I did with the suggested changes. The profile route I had to add only to the original PR.

142d035

<>
<Security oktaAuth={oktaAuth} restoreOriginalUri={restoreOriginalUri}>
<Switch>
<Routes>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Routes>

Leaving Routes there is an accident

<Routes>
<Route path="/" exact component={Home}/>
<Route path="/login/callback" component={LoginCallback}/>
</Routes>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
</Routes>

sorry, no Routes

@@ -1,12 +1,23 @@
You need recent versions of [Node](https://nodejs.org/en/) and [npm](https://www.npmjs.com/).

Create a React app named `okta-react-quickstart` and enter the project route using the following command. This creates a React app using React version 17.
1. Create a Vue app named `okta-react-quickstart` using the following command:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Create a Vue app named `okta-react-quickstart` using the following command:
1. Create a React app named `okta-react-quickstart` using the following command:

oops, that's awkward

<p>
Below is the information from your ID token which was obtained during the &nbsp;
<a href="https://developer.okta.com/docs/guides/implement-auth-code-pkce">PKCE Flow</a>
{' '}
and is now stored in local storage.
</p>
<p>
TRUE?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TRUE?

}
}
const { oktaAuth } = useOktaAuth();
const [messages, setMessages] = useState(null);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const [messages, setMessages] = useState(null);
const [messages, setMessages] = useState([]);

};

fetchMessages();
}, [oktaAuth]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}, [oktaAuth]);
}, [oktaAuth, messages.length]);

```

4. Import `Profile` into `src/App.js` by adding the following:
4. Import `Profile` into `src/App.jsx` by adding the following:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add text about adding a link to /profile similar to what we discussed for Angular

<p>
Below is the information from your ID token which was obtained during the &nbsp;
<a href="https://developer.okta.com/docs/guides/implement-auth-code-pkce">PKCE Flow</a>
{' '}
and is now stored in local storage.
</p>
<p>
TRUE?
This route is protected with the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This route is protected with the
Protect this route with the

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants