feat: add getKeysInterceptor option
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawyu-okta
reviewed
Jun 13, 2024
jaredperreault-okta
force-pushed
the
jp-OKTA-732102
branch
from
3c46ff6 to
76ecf00
Compare
shawyu-okta
approved these changes
Jun 13, 2024
| * This option is passed to the `JwksClient` constructor. Useful when wanting to load key sets from a file, env variable or external cache | ||
| * Read more: https://github.com/auth0/node-jwks-rsa/blob/master/EXAMPLES.md#loading-keys-from-local-file-environment-variable-or-other-externals | ||
| */ | ||
| getKeysInterceptor?(): Promise<JSONWebKey>; |
There was a problem hiding this comment.
?(): haven't seen that before. interesting
| new OktaJwtVerifier({ | ||
| issuer: 'https://foo', | ||
| clientId: '123456', | ||
| getKeysInterceptor: () => [] |
There was a problem hiding this comment.
Won't this throw or result in a type error on the return?
oktapp-aperture-okta bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
OKTA-742085 version 4 breaking: removes `jwt.setXYZ` methods from .verify methods (#47) feat: add `getKeysInterceptor` option (#48)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Reviewers