This repository has been archived by the owner on Oct 24, 2024. It is now read-only.
Ag okta 404546 pr 1010 #1020
Merged
Ag okta 404546 pr 1010 #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids deprecation message and insecure random usages
Caused by update without reading migration guide. Test > e2e > harness > server.js > DemoServer > start now uses random UUID like it used to.
Fixed error in linting where eslint complained about using Promise.reject. This should function the same, without the error while linting
| @@ -37,7 +37,10 @@ const makeTokenRevoker = ({ issuer, client_id, client_secret, errorHandler }) => | |||
| body: querystring.stringify({token, token_type_hint: token_hint}), | |||
| }) | |||
| // eslint-disable-next-line promise/no-nesting | |||
| .then( r => r.ok ? r : r.text().then(message => Promise.reject(new OIDCMiddlewareError('revokeError', message)) )) | |||
| // .then( r => r.ok ? r : r.text().then(message => Promise.reject(new OIDCMiddlewareError('revokeError', message)) )) | |||
There was a problem hiding this comment.
nit: comment can be removed
oleksandrpravosudko-okta
approved these changes
Jul 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges changes from #1010