Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

[oidc-middleware] Add oidcClientOptions #1027

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

denysoblohin-okta
Copy link
Contributor

@denysoblohin-okta denysoblohin-okta commented Aug 4, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

Customer reports then default authorization for /token endpoint (client_secret_basic) doesn't work for some reason (related to configuration of his network probably) but client_secret_post works.

Issue Number: OKTA-379204

What is the new behavior?

Developer can pass custom options to OpenId Client constructor

Should resolve issue okta/samples-nodejs-express-4#105
by adding

    oidcClientOptions: {
      token_endpoint_auth_method: 'client_secret_post',
    }

in options for ExpressOIDC here: https://github.com/okta/samples-nodejs-express-4/blob/master/common/sample-web-server.js#L31

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reviewers

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant