This repository has been archived by the owner on Oct 24, 2024. It is now read-only.
fix[okta-react]: Retain search and hash on ImplicitCallback redirect #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmelberg-okta
approved these changes
May 2, 2018
| @@ -14,11 +14,11 @@ import { browser, element, by, ExpectedConditions } from 'protractor'; | |||
|
|
|||
| export class ProtectedPage { | |||
| navigateTo() { | |||
| return browser.get('/protected'); | |||
| return browser.get('/protected?foo=bar#baz'); | |||
There was a problem hiding this comment.
If possible, lets try and keep the same page objects throughout our front-end integrations (as we want to use shared specs in the future).
Can this be updated to /protected/foo?state=bar? This will allow us to test:
- Nested paths
- Retained query params.
There was a problem hiding this comment.
I'd propose /protected/foo?state=bar#baz then because I also want to assert we preserve fragments (we had issues in the past where they were removed, I think it was an authJS issue that got resolved)
Saves full referrer location object on login Redirects to referrer location object from ImplicitCallback Resolves: #174
* Assert that query strings and hash fragments are persisted on callback * Modify existing test to use the root app page, otherwise it conflicts with the changes to the protected page object
robertjd
force-pushed
the
rd-fix-callback-referrer
branch
from
99767ea to
5500815
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #175 and closes #175 #174
This PR adds a test commit and runs the test in our travis environment.