Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

fix[react-native]: pass consistent UA - OKTA-296091 #790

Merged
merged 6 commits into from
May 28, 2020

Conversation

shuowu
Copy link
Contributor

@shuowu shuowu commented May 27, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • [] Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

okta-react-native currently depends on different upstream sdks to make HTTP request, which end up with different UAs be sent out without react-native info.

Issue Number: N/A
OKTA-296091

What is the new behavior?

Use following pattern to set UA in headers

@okta/okta-react-native/${version} $UPSTREAM_SDK react-native/${version} ${Platform.OS}/${Platform.Version}

Android
Screen Shot 2020-05-27 at 3 51 39 PM

ios
Screen Shot 2020-05-27 at 5 13 35 PM

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reviewers

@shuowu shuowu changed the title Sw react native ua 296091 fix[react-native]: pass consistent UA - OKTA-296091 May 27, 2020
Copy link
Contributor

@FeiChen-okta FeiChen-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@IldarAbdullin-okta IldarAbdullin-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS part looks good!

@shuowu-okta shuowu-okta merged commit f8f3cf7 into master May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants