fix[react]: store secureRouterReferrerPath in sessionStorage #884
Conversation
| @@ -252,13 +252,13 @@ class AuthService { | |||
| if (fromUri.charAt(0) === '/') { | |||
| fromUri = window.location.origin + fromUri; | |||
| } | |||
| localStorage.setItem( 'secureRouterReferrerPath', fromUri ); | |||
| sessionStorage.setItem( 'secureRouterReferrerPath', fromUri ); | |||
There was a problem hiding this comment.
This looks like the kind of issue that blew us up when we had conflicting versions of Auth JS between the SIW and outside the SIW.
@aarongranick-okta - as I recall, the solution was to first check for the localStorage version, then fall back to the sessionStorage, but that won't work for this scenario (which is specifically multiple tabs), right? Am I overthinking this?
There was a problem hiding this comment.
Not sure, but I saw okta-angular is implemented with sessionStorage.
There was a problem hiding this comment.
@swiftone I don't think this will affect the widget. Unlike the PKCE meta which is stored by auth flow initializer (SIW) and read by callback handler (SDK). This value is stored by the SDK before the redirect to SIW, and read by the SDK after the callback has been handled.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: OKTA-282373
What is the new behavior?
Store
secureRouterReferrerPathin sessionStorageDoes this PR introduce a breaking change?
Other information
Reviewers