This repository has been archived by the owner on Oct 24, 2024. It is now read-only.
chore: update configuration-validation dependency of jwt-verifier #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandrpravosudko-okta
force-pushed
the
op-okta-340069-configuration-validation-dependency
branch
from
fe036f9 to
5bb796f
Compare
| @@ -86,11 +90,14 @@ describe('Jwt Verifier', () => { | |||
| }); | |||
| }, LONG_TIMEOUT); | |||
|
|
|||
| it('should fail if no kid is present in the JWT header', () => { | |||
| it('should fail if no kid is present in the JWT header and keys endpoint provides > 1 key', () => { | |||
There was a problem hiding this comment.
to align with jwks-rsa update
oleksandrpravosudko-okta
force-pushed
the
op-okta-340069-configuration-validation-dependency
branch
2 times, most recently
from
5bb796f to
d9ceed0
Compare
shuowu
reviewed
Jan 21, 2021
packages/jwt-verifier/CHANGELOG.md
Outdated
|
|
||
| ### Other | ||
|
|
||
| - [#952](https://github.com/okta/okta-oidc-js/pull/952) - Updates configuration-validation dependency of okta-jwt-verifier to 1.0.0 |
There was a problem hiding this comment.
nit: probably no need to mention okta-jwt-verifier since it's the changelog of jwt-verifier
shuowu
approved these changes
Jan 21, 2021
aarongranick-okta
approved these changes
Jan 21, 2021
oleksandrpravosudko-okta
force-pushed
the
op-okta-340069-configuration-validation-dependency
branch
from
d9ceed0 to
3e63397
Compare
oleksandrpravosudko-okta
deleted the
op-okta-340069-configuration-validation-dependency
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: 340069
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Reviewers