feat: Store device secret in keychain #304
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjlangholtz
force-pushed
the
feat-save-device-secret
branch
from
85ade2a to
1ef76e5
Compare
jjlangholtz
force-pushed
the
feat-save-device-secret
branch
from
1ef76e5 to
e583fdd
Compare
|
Hi @jjlangholtz , Thanks for your contribution. Someone from our team will review it shortly. |
|
Hi, Can someone please review and approve the pull request? We are also facing this issue and need a resolution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds minimal code to write the device secret and id token to the iOS keychain after authentication. This should only happen when the
device_ssoscope is used and adevice_secretis returned with the token response.For our current use-case this would help us implement native SSO flows between our apps until the new SDKs are ready for us to migrate to.