Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression : FR language doesn't work anymore (Last working version: 4.3.0) #1398

Closed
1 task
devopsmica opened this issue Aug 27, 2020 · 4 comments
Closed
1 task

Comments

@devopsmica
Copy link

devopsmica commented Aug 27, 2020

I'm submitting a

  • [x ] bug report
  • feature request

Background info

Using angular and imported through yarn.

Describe your issue or request here (if necessary).
For version 4.3.1, 4.3.2, 4.3.3

image

Expected behavior

For version 4.3.0

image

What should have happened?
It should get the language from the node_module folder.

What went wrong?

Here's what the browser is trying to get :
GET https://global.oktacdn.com/okta-signin-widget/4.3.3-g5ca530e/labels/json/login_fr.json 404
GET https://global.oktacdn.com/okta-signin-widget/4.3.3-g5ca530e/labels/json/country_fr.json 404

Steps to reproduce

No changes to the code outside changing the version.

Your environment

  • Okta Sign-In Widget Version: 4.3.3
  • Browser: Any
  • OS: Linux
  • Language: FR
@swiftone
Copy link
Contributor

@devopsmica - Thanks for the report, I'll bring this to the attention of our internationalization team.

@swiftone
Copy link
Contributor

@devopsmica - it looks like we have a bug that is dropping a hash fragment into the link paths (https://global.oktacdn.com/okta-signin-widget/4.3.3-g5ca530e/labels/json/login_fr.json fails, but https://global.oktacdn.com/okta-signin-widget/4.3.3/labels/json/login_fr.json works)

We'll be pushing an update that will fix this for future widget versions, but in the meantime you should be able to manually specify the correct paths:

  "assets": {
    baseUrl: 'https://global.oktacdn.com/okta-signin-widget/{your widget version}'
}

Thanks for bringing this to our attention, and let us know if this workaround doesn't work!

@swiftone
Copy link
Contributor

internal ref: OKTA-304721

@haishengwu-okta
Copy link
Contributor

@devopsmica we have fixed in 4.3.4. Please let us know if further issues. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants