-
Notifications
You must be signed in to change notification settings - Fork 232
Adds i18n config test to be used in widget PDV #893
Conversation
3e9b23e
to
a30771d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! a couple of nits.
Question:
what's usage of harness/start-custom-login-server.js
?
I assume specs/custom-login-page.js
is for running test.
(The initial code looks identical and wonder if could be consolidated.)
@@ -12,16 +12,25 @@ | |||
|
|||
const constants = require('../util/constants'); | |||
const util = require('../util/util'); | |||
let options = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: looks like options
can be const
@@ -12,16 +12,25 @@ | |||
|
|||
const constants = require('../util/constants'); | |||
const util = require('../util/util'); | |||
let options = {}; | |||
let cdnUrl = 'https://global.oktacdn.com/okta-signin-widget/4.4.1'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: would be simplified a little bit as
let widgetVersion = '4.4.1';
if (env.NPM_TARBAR_URL) {
widgetVersion = version;
}
const cdnUrl = `https://global.oktacdn.com/okta-signin-widget/${widgetVersion}`;
This is if a user wants to start a custom login server without running tests. |
e031302
to
3562048
Compare
3562048
to
185db15
Compare
185db15
to
7b4d702
Compare
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Reviewers