Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide promo banner #1542

Merged
merged 1 commit into from
Oct 31, 2024
Merged

hide promo banner #1542

merged 1 commit into from
Oct 31, 2024

Conversation

edunham
Copy link
Member

@edunham edunham commented Oct 29, 2024

This reverts commit 1211b97.

This blog post has the following features:

  • A GitHub Repository with a polished README
  • A GitHub Repository under the github.com/oktadev account
  • A title that's approved by Dev Advocacy
  • A URL approved by Dev Advocacy
  • The content has been run through Grammarly (https://www.grammarly.com/)
  • Rendered locally and confirmed that no Markdown typos exist
  • Images are compressed appropriately
  • Social image previews well on Twitter and LinkedIn
  • Tech review request (developer advocate or domain expert)
  • Review request for editorial/grammar/clarity (developer advocate or Colton)

@netlify Netlify
Copy link

netlify bot commented Oct 29, 2024 •
edited
Loading

✅ Deploy Preview for okta-blog ready!

Name Link
🔨 Latest commit 6fe9546
🔍 Latest deploy log https://app.netlify.com/sites/okta-blog/deploys/67214b61339d6c000862feaa
😎 Deploy Preview https://deploy-preview-1542--okta-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

alisaduncan
alisaduncan requested changes Oct 29, 2024
View reviewed changes
Copy link
Member

@alisaduncan alisaduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of reverting the PR, can we just hide the banner please?

alisaduncan
alisaduncan reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@alisaduncan alisaduncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing to comment so it doesn't block merge, but respectfully requesting changing the flag instead of reverting the PR.

@edunham
Copy link
Member Author

edunham commented Oct 29, 2024

swapped it over to just hide the banner. I'd assumed we might want to resume promo on the workshops soonish, but I have no objections to leaving the rest in the oktane promo state for now.

@edunham edunham changed the title Revert "Oktane promo banner (#1532)" hide promo banner Oct 29, 2024
@isemona isemona merged commit 14570bf into oktadev:main Oct 31, 2024
6 checks passed
@isemona
Copy link
Contributor

isemona commented Oct 31, 2024

confirmed with @edunham good to close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isemona isemona isemona approved these changes

@alisaduncan alisaduncan alisaduncan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edunham @isemona @alisaduncan