This repository has been archived by the owner on Sep 16, 2019. It is now read-only.
Fix Windows regex issues in Webpack config #1249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the way Windows handles paths/slashes, Webpack was not catching (and consequently, not transpiling) the foundation-sites folder, leading to corrupted/failed JS builds. Tested in Windows 10/Ubuntu 16.04/OSX High Sierra.
|
@conorbarclay Should we combine this PR with #1202 and the issue with interchange images not showing in IE. Sort of related. I don't think it was ever addressed. |
|
Oh crap, you beat me to this. Sorry @conorbarclay I didn't notice your PR. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way Windows handles paths/slashes, Webpack was not catching (and consequently, not transpiling) the foundation-sites folder, leading to corrupted/failed JS builds. Tested in Windows 10/Ubuntu 16.04/OSX High Sierra.
Before opening a pull request, please make sure to do the following:
See: #1219