Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the 'in-cluster' env var #38

Merged
merged 1 commit into from
Aug 11, 2019
Merged

Conversation

CKarper
Copy link
Collaborator

@CKarper CKarper commented Aug 9, 2019

Fixes #34

@olegsu
Copy link
Owner

olegsu commented Aug 10, 2019

@CKarper thanks!
Please update the version in VERSION file to 0.5.0 to create also new release packages.

@CKarper
Copy link
Collaborator Author

CKarper commented Aug 10, 2019

I can bump in this PR, but I have the other 2 PRs that I'd like included in any new release as well. If you have some time to give feedback on those.

@@ -1 +1 @@
0.4.0
0.4.1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this was just a bug fix, I made it a patch version change.

@olegsu olegsu merged commit 4657dde into olegsu:master Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No "In Cluster" env var available.
2 participants