Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a matcher for windows path backslashes #102

Merged
merged 1 commit into from
Jul 15, 2023

Conversation

Alexendoo
Copy link
Contributor

Fixes #89

Slightly different than the rustc one, it assumes it will be ran against generally unsubstituted paths (no $DIR\foo\...) because Config::path_stderr_filter switches the \s in windows paths to /

It does require an extra feature enabled on regex for the unicode property escapes

@oli-obk
Copy link
Owner

oli-obk commented Jul 15, 2023

You need to run cargo test and commit the changed .stderr files

@oli-obk oli-obk merged commit ff66c4d into oli-obk:main Jul 15, 2023
@oli-obk
Copy link
Owner

oli-obk commented Jul 15, 2023

cool, I can probably start removing a bunch of weird ad-hoc filters in my tests now :D

@Alexendoo Alexendoo deleted the windows-paths branch July 15, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a backslash escaping heuristic to keep non-path backslashes around
2 participants