Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runtime): throw on wrong pattern #79

Merged
merged 1 commit into from
Feb 4, 2017

Conversation

oliviertassinari
Copy link
Owner

@oliviertassinari oliviertassinari commented Feb 4, 2017

I hope this new error won't be affected by false positive.
We can track the number of occurrences with that analytics.
The warning looks like this:

     SyntaxError: You are accessing the propTypes from an imported Identifier.
It's likely to break at runtime. Instead, import the propTypes.
For more details, have a look at this issue: https://goo.gl/sHDdUk.
    34 |
    35 | const propTypes = {
  > 36 |   value: SomeComponent.propTypes.value,
       |          ^
    37 | };

Closes #70

@oliviertassinari oliviertassinari merged commit 62943d3 into master Feb 4, 2017
@oliviertassinari oliviertassinari deleted the throw-on-wrong-pattern branch February 4, 2017 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant