Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171
In the
Hue
component:aria-valuetext
has been changed toaria-valuenow
. Since the "human understandable" value is numeric, we don't need bothvaluetext
andvaluenow
, andvaluenow
is the "required" attributearia-valuemin
has been set to 0 andaria-valuemax
has been set to 360 to provide a bit more context for screen reader usersIn the
Alpha
component:aria-valuenow
has been added. This is in addition toaria-valuetext
. Screen readers will generally read out the more understandablevaluetext
, butvaluenow
is a required attribute to accompany itaria-valuemin
has been set to 0 andaria-valuemax
has been set to 100In the
Saturation
component:No change has been made! I don't believe there is an available numeric representation of the current value, so in this case I believe we can omit
aria-valuenow
for the time being until #152 is addressed.Snapshot tests have been updated to reflect the new attributes 🙂
Check out the docs for
aria-valuenow
for more context