Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require pyyaml 6.0+ due to CVE-2020-14343 #890

Closed
wants to merge 1 commit into from

Conversation

tony--
Copy link
Contributor

@tony-- tony-- commented Mar 15, 2022

Existing Sample Changes

Description

pyyaml < 6.0 is vulnerable to CVE-2020-14343 and/or related gap in original fix. See discussion here. In order to safeguard users, we should require pyyaml 6.0+.

External Dependencies

None

Type of change

Please delete options that are not relevant. Add a 'X' to the one that is applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Implement fixes for ONSAM Jiras

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

No testing. This PR is meant to illustrate a proposed change for review and testing by the sample owner.

Copy link
Contributor

@praveenkk123 praveenkk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for CI test only

@praveenkk123
Copy link
Contributor

Hi Tony,
We are closing the PR as we retired the sample.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants