Shared System Health collector should export zero when no health issu… #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es are present Signed-off-by: Russell Troxel <[email protected]>
onedr0p
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…es are present
Description of the change
As title -- system_health_issues was treated like an info metric (always export 1, conveying meaning via labels), but is frequently used as a count. To faciliate this without everyone needing to
OR vector(0), we should just export a zero metric when no health issues are present.Benefits
Possible drawbacks
Applicable issues
sonarr_system_health_issuesonly exists in the dashboard2, not as an exported metric #134Additional information