Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add script to get Approved nodes list #254

Merged
merged 11 commits into from
Nov 9, 2021

Conversation

kc1116
Copy link
Contributor

@kc1116 kc1116 commented Oct 13, 2021

This PR adds a script to get the approved nodes list from the staking table.

@kc1116 kc1116 requested a review from joshuahannan as a code owner October 13, 2021 19:38
@kc1116 kc1116 requested a review from jordanschalm October 13, 2021 19:38
@jordanschalm
Copy link
Member

jordanschalm commented Oct 13, 2021

@kc1116 You should be able to use the existing getProposedNodeIDs script for the purposes of epochs integration testing. This will check both that the node ID is on the approved list and that it has sufficient stake (for our tests, we will need both these to be true).

Copy link
Member

@jordanschalm jordanschalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one comment

totalStakedFilename = "idTableStaking/scripts/get_total_staked.cdc"
rewardRatioFilename = "idTableStaking/scripts/get_node_type_ratio.cdc"
weeklyPayoutFilename = "idTableStaking/scripts/get_weekly_payout.cdc"
getApprovedNodes = "idTableStaking/scripts/get_approved_nodes.cdc"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
getApprovedNodes = "idTableStaking/scripts/get_approved_nodes.cdc"
getApprovedNodesFilename = "idTableStaking/scripts/get_approved_nodes.cdc"

kc1116 and others added 9 commits October 14, 2021 11:47
* Multi unlock

* Add function for code template generation

* Update transaction

* Tests for unlocking script (#253)

* tests for unlocking script

* merge conflict fix

* gas usage test

* more tests

* make ci

* remove unnecessary line

* fixing comment

Co-authored-by: Joshua Hannan <[email protected]>
…low-core-contracts into khalil/1607-read-approved-nodes
@joshuahannan joshuahannan merged commit 134c661 into master Nov 9, 2021
@joshuahannan joshuahannan deleted the khalil/1607-read-approved-nodes branch November 9, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants