Set staking auction length explicitly in resetEpoch
#268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuahannan
approved these changes
Jan 3, 2022
There was a problem hiding this comment.
Looks good to me! Would it make sense to try to include this in the same upgrade that we do for the automated rewards calculation and payment?
We can probably just merge this though and I'll integrate the changes into my PR
👍 That makes sense. This should be ready for the next (mid-February) spork cycle. |
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Jan 18, 2022
1804: Include staking auction length in `resetEpoch` r=jordanschalm a=jordanschalm This PR updates the transaction argument generation tool for `resetEpoch` to include the `stakingEndView` parameter added in onflow/flow-core-contracts#268.⚠️ Before merging, tag a release for `core-contracts` including onflow/flow-core-contracts#267. Co-authored-by: Jordan Schalm <[email protected]>
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Jan 18, 2022
1804: Include staking auction length in `resetEpoch` r=jordanschalm a=jordanschalm This PR updates the transaction argument generation tool for `resetEpoch` to include the `stakingEndView` parameter added in onflow/flow-core-contracts#268.⚠️ Before merging, tag a release for `core-contracts` including onflow/flow-core-contracts#267. Co-authored-by: Jordan Schalm <[email protected]>
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Jan 18, 2022
1804: Include staking auction length in `resetEpoch` r=jordanschalm a=jordanschalm This PR updates the transaction argument generation tool for `resetEpoch` to include the `stakingEndView` parameter added in onflow/flow-core-contracts#268.⚠️ Before merging, tag a release for `core-contracts` including onflow/flow-core-contracts#267. Co-authored-by: Jordan Schalm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resetEpochcurrently sets the staking auction length based on the config in the contract, rather than inputs to the function, which can be unsafe. See https://github.com/dapperlabs/flow-go/issues/6076 for details.This PR adds the
stakingEndViewas an argument toresetEpoch.FlowEpoch, and must be rolled out in tandem with theflow-gotooling changes described in https://github.com/dapperlabs/flow-go/issues/6076 (in-progress)