Update crypto algorithm checks for account keys #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuahannan
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Looks good! You'll also need to update /lib/go/templates/cmd/mainifest/manifest.go to remove the weight argument from the sample arguments for the create account transaction. And then this will affect the ledger transactions, so make sure this gets pulled into the feature branch as soon as you merge it
|
Good point 👌🏼 I removed the weight argument in 7223cd9 |
joshuahannan
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #460
Account keys can only use:
All other combinations should be rejected early by the transactions.