Skip to content

Commit

Permalink
fix(input/#2428) - Input text component + textInputFocus context key …
Browse files Browse the repository at this point in the history
…fixes (#2433)

This is more groundwork being laid to support #528 , which requires us to refine our focus management story. This enables features to conditional expose context keys (which may be from nested items - like the sidebar exposing `textInputFocus` when an input control has focus in a sidebar item...)

This moves `InputText` to a component - a rich component that exposes context keys, potentially keybindings, subscriptions, etc. I'll follow this same model for some additional rich components I'll be adding to support #528 

I started a debug view for input / context keys in #2427 , it's ugly right now - but it shows the `textInputFocus` key being set as expected in various scenarios:

![2020-09-10 15 32 01](https://user-images.githubusercontent.com/13532591/92817678-aef46280-f37b-11ea-82d7-fb5c4046c203.gif)

This fixes the `textInputFocus` part of #2428 , and requires a revery fix for drop-shadow to give more emphasis around text-inputs having focus: revery-ui/revery#999
  • Loading branch information
bryphe authored Sep 11, 2020
1 parent 6a758ea commit 53e86a2
Show file tree
Hide file tree
Showing 46 changed files with 577 additions and 411 deletions.
46 changes: 22 additions & 24 deletions bench.esy.lock/index.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

34 changes: 0 additions & 34 deletions bench.esy.lock/opam/fpath.0.7.2/opam

This file was deleted.

36 changes: 36 additions & 0 deletions bench.esy.lock/opam/fpath.0.7.3/opam

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

46 changes: 22 additions & 24 deletions esy.lock/index.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 53e86a2

Please sign in to comment.