New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pane/#2408): Toggle Problems Pane not working #2412

Merged

bryphe merged 1 commit into master from fix/problems/2408/toggle-not-working

Sep 7, 2020

Member

bryphe commented Sep 5, 2020 •

edited

Loading

Issue: The toggle-problems-pane command (bound to Control+Shift+M/Command+Shift+M) wasn't working. The command and key-binding had no effect.

Defect: The 'workbench.actions.view.problems' command wasn't actually wired up to our action.

Fix:

Move the 'workbench.actions.view.problems' to a contributed command from the Pane feature
Move the Control+Shift+M / Command+Shift+M bindings to contributed keybindings from the Pane feature
Wire up the logic for showing / hiding the problems pane.

Fixes #2408 - still need to wire up vim-style navigation to it, though (in the spirit for #528)


          Re-wire toggle-problems / diagnostics command key-binding

21d5c2a

bryphe mentioned this pull request

Toggle Problems command does not toggle problems panel #2408

Closed

bryphe merged commit f698991 into master

bryphe deleted the fix/problems/2408/toggle-not-working branch

September 7, 2020 16:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet