feat(ux): Initial focus plumbing for the pane #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
bryphe
added a commit
that referenced
this pull request
Sep 19, 2020
This is another step towards #528 - this creates a vim-navigable list component to be reused across portions of our UI. In this PR, it's hooked up to search:  __TODO - Blocking check-in:__ - [x] Fix diagnostics pane (requires #2466, #2478 ) - [x] Remove 'LocationList', which is replaced by the vim-navigable list + `LocationListItem` Next steps: - Hook up the vim-navigable-list to SCM - Hook up the vim-navigable-list to Extensions - Hook up the vim-navigable-list to Notifications (requires #2466) - Create a vim-navigable-tree, to be used with the file explorer - and can address #528 - Hook up search `/` / `?` - Improve the UX of the search pane, so that the results are more visible - it's not very useful in the current form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wires up the Pane so that it is recognized as a keyboard-focusable area - a pre-req to setting up vim-style navigation for the diagnostics / quickfix view.