fix(explorer/#528): #528 - Part 1 - Initial vim navigation for Explorer #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
3 tasks
bryphe
added a commit
that referenced
this pull request
Sep 30, 2020
Following from #2502, and working towards #528, this adds `/` & `?` search functionality for the explorer, search results, and diagnostics:  __TODO:__ - [x] When the search query changes, focus the next match. - [x] Tweak theme colors - the 'active' background is a bit intense for the search bar, and the foreground search icon is drowned out - [x] Add additional 'selection' indication - in some themes, it's hard to differentiate search results vs selection __Additional work:__ - Set up `yy` (copy), `dd` (cut), and `p` gestures for the vim list, and support in the file explorer - Set up `o` and `O` gestures in file explorer to insert a new file - Visual mode primitives - `v`/`V` to switch to visual mode for multi-selection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in the the vim-navigable-tree introduced in #2492 , and wires it up to the file explorer:
This supports some initial vim-style navigation, like j/k/zz/zb/zt.
There are a few additional gestures I'd like to support, to be able to resolve (soon) #528 :
/,?,n,N) experienceyy,dd,pp).