Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input/#2604): Ex keybinding fails #2713

Merged
merged 1 commit into from
Nov 14, 2020

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Nov 14, 2020

Issue: Binding to some ex commands - like :enew - aren't working as expected. In the :enew case, no buffer is opened.

Defect: The effects are being ignored, so there is no buffer transition

Fix: Re-use the effect logic in VimStoreConnector to handle this (use the VimExecuteCommand action).

Fixes #2604

@bryphe bryphe merged commit d80edd5 into master Nov 14, 2020
@bryphe bryphe deleted the fix/input/2604/ex-keybinding-fails branch November 14, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keybinding to :enew does nothing
1 participant