Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

it seems mypy on CI doesn't work #219

Closed
kmyk opened this issue Dec 31, 2018 · 2 comments
Closed

it seems mypy on CI doesn't work #219

kmyk opened this issue Dec 31, 2018 · 2 comments

Comments

@kmyk
Copy link
Member

kmyk commented Dec 31, 2018

see #218
kmyk added a commit that referenced this issue Dec 31, 2018
@kmyk
#219: add a line to fail on type checking
0c0e99f 
$ mypy --ignore-missing-imports oj
onlinejudge/implementation/main.py:348: error: Incompatible types in assignment (expression has type "str", variable has type "int")
kmyk added a commit that referenced this issue Dec 31, 2018
@kmyk
#219: update the command to call mypy
21126c3
kmyk added a commit that referenced this issue Dec 31, 2018
@kmyk
Revert "#219: add a line to fail on type checking"
4764ee1 
This reverts commit 0c0e99f.
@kmyk
Copy link
Member Author

kmyk commented Dec 31, 2018

#220 はちゃんとfailしました 🎉

kmyk added a commit that referenced this issue Dec 31, 2018
@kmyk
Merge pull request #221 from kmyk/fix/mypy
14ec4a0 
#219
@kmyk
Copy link
Member Author

kmyk commented Dec 31, 2018

👌

@kmyk kmyk closed this as completed Dec 31, 2018
@kmyk kmyk mentioned this issue Dec 31, 2018
Merged
kmyk added a commit that referenced this issue Jan 2, 2019
@kmyk
#219: put --verbose option to mypy to see what files are type-checked
1b4e4f5
kmyk added a commit that referenced this issue Jan 2, 2019
@kmyk
#219: set deploy.on.python of .travis.yml to ensure the version and d…
e8951c3 
…eploying just once
kmyk added a commit that referenced this issue Jan 2, 2019
@kmyk
#219: set the Python version 3.6 of Trove classifier
9f06ba6 
Now this works on 3.5, but mainly, 3.6 is supported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kmyk