Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring #225

Closed
kmyk opened this issue Jan 2, 2019 · 2 comments
Closed

refactoring #225

kmyk opened this issue Jan 2, 2019 · 2 comments

Comments

@kmyk
Copy link
Member

kmyk commented Jan 2, 2019

No description provided.

@kmyk
Copy link
Member Author

kmyk commented Jan 2, 2019

  • use __about__.py instead of a version.py
  • make onlinejudge.service.* for atcoder.py, codeforces.py, etc.
  • unify service.py, problem.py and submission.py into type.py
  • rename some methods like Problem.download()

kmyk added a commit that referenced this issue Jan 2, 2019
@kmyk
#225: start using pathlib
7d69c93
kmyk added a commit that referenced this issue Jan 2, 2019
@kmyk
#225: rename version.py to __about__.py
1c9f521
kmyk added a commit that referenced this issue Jan 2, 2019
@kmyk
#225: rename the variable in __about__.py
082f26e
@kmyk kmyk mentioned this issue Jan 2, 2019
Merged
kmyk added a commit that referenced this issue Jan 2, 2019
@kmyk
#225: rename the variable in __about__.py
70346d1
kmyk added a commit that referenced this issue Jan 2, 2019
@kmyk
#225: rename version.py to __about__.py
5469b20
kmyk added a commit that referenced this issue Jan 2, 2019
@kmyk
#225: rename the variable in __about__.py
0627772
kmyk added a commit that referenced this issue Jan 2, 2019
@kmyk
Merge pull request #228 from kmyk/issue/225
7b18af8 
#225
kmyk added a commit that referenced this issue Jan 2, 2019
@kmyk
#225: unify service.py, problem.py and submission.py into type.py
0d5aa23
kmyk added a commit that referenced this issue Jan 2, 2019
@kmyk
#225: make onlinejudge.service directory
fb1f614
kmyk added a commit that referenced this issue Jan 2, 2019
@kmyk
#225: rename some methods
f8258a9
kmyk added a commit that referenced this issue Jan 2, 2019
@kmyk
#225: use pathlib
915f4ef
kmyk added a commit that referenced this issue Jan 2, 2019
@kmyk
#225: make onlinejudge.service directory
b00c716
kmyk added a commit that referenced this issue Jan 2, 2019
@kmyk
#225: rename some methods
230b391
kmyk added a commit that referenced this issue Jan 2, 2019
@kmyk
#225: use pathlib
d2c28a7
kmyk added a commit that referenced this issue Jan 2, 2019
@kmyk
#225: sphinx-apidoc -o docs onlinejudge
c8816c4
kmyk added a commit that referenced this issue Jan 2, 2019
@kmyk
#225: split tests/download.py
89d8bd9
kmyk added a commit that referenced this issue Jan 2, 2019
@kmyk
#225: clean up about import
de94604
kmyk added a commit that referenced this issue Jan 2, 2019
@kmyk
#225: print a specialized message when NotImplementedError is raised
640442a
kmyk added a commit that referenced this issue Jan 2, 2019
@kmyk
Merge pull request #230 from kmyk/issue/225c
a00d74b 
#225
@kmyk kmyk closed this as completed Jan 2, 2019
@kmyk
Copy link
Member Author

kmyk commented Jan 2, 2019

時間かかりすぎててなんだか人生を無駄にした感がある

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kmyk